From 0a84850d91671606c6272fe4679e27dd68daf88e Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Sun, 24 Sep 2023 21:05:50 -0400 Subject: bcachefs: nocow locking: Fix lock leak Signed-off-by: Kent Overstreet --- fs/bcachefs/io_write.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/bcachefs/io_write.c b/fs/bcachefs/io_write.c index d2a0de886c7a..6e4f85eb6ec8 100644 --- a/fs/bcachefs/io_write.c +++ b/fs/bcachefs/io_write.c @@ -1376,10 +1376,12 @@ err_get_ioref: /* Fall back to COW path: */ goto out; err_bucket_stale: - while (--i >= 0) + while (i >= 0) { bch2_bucket_nocow_unlock(&c->nocow_locks, buckets[i].b, BUCKET_NOCOW_LOCK_UPDATE); + --i; + } for (i = 0; i < nr_buckets; i++) percpu_ref_put(&bch_dev_bkey_exists(c, buckets[i].b.inode)->io_ref); -- cgit v1.2.3