diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-09-11 10:09:02 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-13 08:52:58 +0100 |
| commit | 754e3c0c31c96cf3a4a54ed2a8c63cca28109136 (patch) | |
| tree | 35b384b85f2aece7a2abc15be909ebe582bc3ee9 | |
| parent | 5119ffd480b644d8bc9af741cc8ef435a7ec5ff7 (diff) | |
net: qrtr: fix memort leak in qrtr_tun_write_iter
commit a21b7f0cff1906a93a0130b74713b15a0b36481d upstream.
In qrtr_tun_write_iter the allocated kbuf should be release in case of
error or success return.
v2 Update: Thanks to David Miller for pointing out the release on success
path as well.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/qrtr/tun.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c index ccff1e544c21..e35869e81766 100644 --- a/net/qrtr/tun.c +++ b/net/qrtr/tun.c @@ -84,11 +84,14 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from) if (!kbuf) return -ENOMEM; - if (!copy_from_iter_full(kbuf, len, from)) + if (!copy_from_iter_full(kbuf, len, from)) { + kfree(kbuf); return -EFAULT; + } ret = qrtr_endpoint_post(&tun->ep, kbuf, len); + kfree(kbuf); return ret < 0 ? ret : len; } |