diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-01-08 00:04:30 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-02-03 21:48:49 -0500 |
| commit | a8281b71f9862a4475e266980a0b5aaf7f0d7548 (patch) | |
| tree | 0642c15f5283b4aa91206daf3bdef711bb173af4 | |
| parent | 87b5db55257b40630ad819e0616bf12bb2a72302 (diff) | |
bcachefs: Fix bch2_btree_path_traverse_all()
We need to take a ref on a path while we're traversing it: this fixes a
bug with paths getting reused while being traversed, in the key cache
fill code.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/btree_iter.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c index 145f25cab905..98991c2f7af9 100644 --- a/fs/bcachefs/btree_iter.c +++ b/fs/bcachefs/btree_iter.c @@ -999,7 +999,10 @@ retry_all: * the same position: */ if (path->uptodate) { + __btree_path_get(path, false); ret = btree_path_traverse_one(trans, path, 0, _THIS_IP_); + __btree_path_put(path, false); + if (bch2_err_matches(ret, BCH_ERR_transaction_restart) || ret == -ENOMEM) goto retry_all; |