summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2021-09-30 15:45:42 -0700
committerDarrick J. Wong <djwong@kernel.org>2021-10-22 16:41:17 -0700
commit058725b83f3ab866a225aec3bfa204c0b7f4d3a8 (patch)
treeebcbf45bfbf3b158104a0994b4e5d08ce86d763d
parent1bc71fc8c51d5b0ac41558cba475e013b3cf1fb8 (diff)
xfs: don't freeze fs for rmap repairsrepair-rmap-live_2021-10-22
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
-rw-r--r--fs/xfs/scrub/rmap_repair.c10
-rw-r--r--fs/xfs/scrub/rtrmap.c14
2 files changed, 0 insertions, 24 deletions
diff --git a/fs/xfs/scrub/rmap_repair.c b/fs/xfs/scrub/rmap_repair.c
index e22b870c399f..147430f8ce4f 100644
--- a/fs/xfs/scrub/rmap_repair.c
+++ b/fs/xfs/scrub/rmap_repair.c
@@ -127,16 +127,6 @@ xrep_setup_ag_rmapbt(
{
int error;
- /*
- * Freeze out anything that can lock an inode. We reconstruct
- * the rmapbt by reading inode bmaps with the AGF held, which is
- * only safe w.r.t. ABBA deadlocks if we're the only ones locking
- * inodes.
- */
- error = xchk_fs_freeze(sc);
- if (error)
- return error;
-
/* Check the AG number and set up the scrub context. */
error = xchk_setup_fs(sc);
if (error)
diff --git a/fs/xfs/scrub/rtrmap.c b/fs/xfs/scrub/rtrmap.c
index e76ad05bc0bb..db1ec51acff2 100644
--- a/fs/xfs/scrub/rtrmap.c
+++ b/fs/xfs/scrub/rtrmap.c
@@ -36,20 +36,6 @@ xchk_setup_rtrmapbt(
struct xfs_mount *mp = sc->mp;
int error = 0;
-#ifdef CONFIG_XFS_ONLINE_REPAIR
- if (sc->sm->sm_flags & XFS_SCRUB_IFLAG_REPAIR) {
- /*
- * Freeze out anything that can lock an inode. We reconstruct
- * the rtrmapbt by reading inode bmaps with the rtrmapbt inode
- * locked, which is only safe w.r.t. ABBA deadlocks if we're
- * the only ones locking inodes.
- */
- error = xchk_fs_freeze(sc);
- if (error)
- return error;
- }
-#endif
-
error = xchk_setup_fs(sc);
if (error)
return error;