diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-03-16 12:47:35 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-03-16 13:48:39 -0400 |
| commit | c4b5c34d683153e4ee89ea4fcf7a70603d124e5d (patch) | |
| tree | 2ec47b2ab96731f74e9572702717571679e25954 | |
| parent | 3be772f4b06160bc75bf52864349140169340978 (diff) | |
bcachefs: Improve error handling in bch2_ioctl_subvolume_destroy()
Pure style fixes
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/fs-ioctl.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c index 2bb680827b44..571b4dca4d39 100644 --- a/fs/bcachefs/fs-ioctl.c +++ b/fs/bcachefs/fs-ioctl.c @@ -451,19 +451,20 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp, return ret; if (path.dentry->d_sb->s_fs_info != c) { - path_put(&path); - return -EXDEV; + ret = -EXDEV; + goto err; } dir = path.dentry->d_parent->d_inode; ret = __bch2_unlink(dir, path.dentry, true); - if (!ret) { - fsnotify_rmdir(dir, path.dentry); - d_delete(path.dentry); - } - path_put(&path); + if (ret) + goto err; + fsnotify_rmdir(dir, path.dentry); + d_delete(path.dentry); +err: + path_put(&path); return ret; } |