summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2019-03-01 15:51:57 -0500
committerKent Overstreet <kent.overstreet@gmail.com>2019-04-03 12:44:08 -0400
commit24528ee4a9a2c90e03d2986dbdca2160bc90cae9 (patch)
tree6d5eb11b47a6b8fdb7931d578bbba990d2a41e36
parente283524155ece5ab66eaf057f366f83e7fb4e79d (diff)
bcachefs: Drop a faulty assertion
the assertion was meant to check that bch2_journal_reclaim_fast() was always being called, but since the atomic dec can happen outside of j->lock the assertion itself can race
-rw-r--r--fs/bcachefs/journal_reclaim.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/bcachefs/journal_reclaim.c b/fs/bcachefs/journal_reclaim.c
index b928b8c8705f..b8603a1ff1f2 100644
--- a/fs/bcachefs/journal_reclaim.c
+++ b/fs/bcachefs/journal_reclaim.c
@@ -332,8 +332,6 @@ journal_get_next_pin(struct journal *j, u64 max_seq, u64 *seq)
spin_lock(&j->lock);
- BUG_ON(!atomic_read(&fifo_peek_front(&j->pin).count));
-
fifo_for_each_entry_ptr(pin_list, &j->pin, *seq)
if (*seq > max_seq ||
(ret = list_first_entry_or_null(&pin_list->list,