summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-02-23 16:49:53 +0800
committerJakub Kicinski <kuba@kernel.org>2022-02-24 21:21:20 -0800
commitd434ee9dee6dc75984897f183df773427a68a1ff (patch)
treea292a632db64252c99d9a7db4aed468b7c54fcf5
parent06388a03d2a792b017d67457012c4f289bf45e13 (diff)
net: marvell: prestera: Fix return value check in prestera_fib_node_find()
rhashtable_lookup_fast() returns NULL pointer not ERR_PTR(), so it can return fib_node directly in prestera_fib_node_find(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20220223084954.1771075-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/marvell/prestera/prestera_router_hw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
index d62adb970dd5..5b0cf3be9a9e 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
@@ -239,7 +239,7 @@ prestera_fib_node_find(struct prestera_switch *sw, struct prestera_fib_key *key)
fib_node = rhashtable_lookup_fast(&sw->router->fib_ht, key,
__prestera_fib_ht_params);
- return IS_ERR(fib_node) ? NULL : fib_node;
+ return fib_node;
}
static void __prestera_fib_node_destruct(struct prestera_switch *sw,