diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-24 14:46:58 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-25 01:48:42 -0400 |
| commit | c8498e7253006090d0fdd680755ebfde24034fb1 (patch) | |
| tree | 6b857c46f961d797ba4e1e86b02fc6d5bd7e7d5e | |
| parent | 98b46d76b854719af45118bd6376ce2169c6c473 (diff) | |
closures: Better memory barriers
atomic_(dec|sub)_return_release() are a thing now - use them.
Also, delete the useless barrier in set_closure_fn(): it's redundant
with the memory barrier in closure_put(0.
Since closure_put() would now otherwise just have a release barrier, we
also need a new barrier when the ref hits 0 -
smp_acquire__after_ctrl_dep().
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | include/linux/closure.h | 2 | ||||
| -rw-r--r-- | lib/closure.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/closure.h b/include/linux/closure.h index 722a586bb224..bdab17050bc8 100644 --- a/include/linux/closure.h +++ b/include/linux/closure.h @@ -233,8 +233,6 @@ static inline void set_closure_fn(struct closure *cl, closure_fn *fn, closure_set_ip(cl); cl->fn = fn; cl->wq = wq; - /* between atomic_dec() in closure_put() */ - smp_mb__before_atomic(); } static inline void closure_queue(struct closure *cl) diff --git a/lib/closure.c b/lib/closure.c index 2958169ce833..545b9726d1ea 100644 --- a/lib/closure.c +++ b/lib/closure.c @@ -22,6 +22,8 @@ static inline void closure_put_after_sub(struct closure *cl, int flags) panic("closure_put_after_sub: bogus flags %x remaining %i", flags, r); if (!r) { + smp_acquire__after_ctrl_dep(); + if (cl->fn && !(flags & CLOSURE_DESTRUCTOR)) { atomic_set(&cl->remaining, CLOSURE_REMAINING_INITIALIZER); @@ -44,7 +46,7 @@ static inline void closure_put_after_sub(struct closure *cl, int flags) /* For clearing flags with the same atomic op as a put */ void closure_sub(struct closure *cl, int v) { - closure_put_after_sub(cl, atomic_sub_return(v, &cl->remaining)); + closure_put_after_sub(cl, atomic_sub_return_release(v, &cl->remaining)); } EXPORT_SYMBOL(closure_sub); @@ -53,7 +55,7 @@ EXPORT_SYMBOL(closure_sub); */ void closure_put(struct closure *cl) { - closure_put_after_sub(cl, atomic_dec_return(&cl->remaining)); + closure_put_after_sub(cl, atomic_dec_return_release(&cl->remaining)); } EXPORT_SYMBOL(closure_put); |