summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@linux.dev>2023-01-18 07:05:47 -0500
committerKent Overstreet <kent.overstreet@linux.dev>2023-05-13 00:22:30 -0400
commite94c1ea78329ed8c521d805d35edbeaceaee6317 (patch)
tree83bc89d78a8f88c0aac6fb233b078421140a8c8e
parent15107597629382f11c087bb0260a547e3fb47c9c (diff)
fs/aio: Use kmap_local() instead of kmap()
Originally, we used kmap() instead of kmap_atomic() for reading events out of the completion ringbuffer because we're using copy_to_user(), which can fault. Now that kmap_local() is a thing, use that instead. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> Cc: Benjamin LaHaise <bcrl@kvack.org Cc: linux-aio@kvack.org Cc: linux-fsdevel@vger.kernel.org
-rw-r--r--fs/aio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/aio.c b/fs/aio.c
index b0b17bd098bb..e1ba4b83998d 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -1250,10 +1250,10 @@ static long aio_read_events_ring(struct kioctx *ctx,
avail = min(avail, nr - ret);
avail = min_t(long, avail, AIO_EVENTS_PER_PAGE - pos);
- ev = kmap(page);
+ ev = kmap_local_page(page);
copy_ret = copy_to_user(event + ret, ev + pos,
sizeof(*ev) * avail);
- kunmap(page);
+ kunmap_local(ev);
if (unlikely(copy_ret)) {
ret = -EFAULT;