diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2019-04-17 20:34:24 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@gmail.com> | 2019-04-17 20:34:24 -0400 |
| commit | 27c447e5ff54b2b09f9d059e834d03f76c0eec30 (patch) | |
| tree | a7f5428f19c818cae607d38a82a6d39ef0d6fac3 | |
| parent | bf69eda15f4b87ecfa8a78d1941bbb1e85feffeb (diff) | |
bcachefs: Fix fsync error reporting
| -rw-r--r-- | fs/bcachefs/fs-io.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index b2ea783fe38a..7133482eeab6 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -1189,9 +1189,10 @@ static void bch2_writepage_io_done(struct closure *cl) unsigned i; if (io->op.op.error) { - bio_for_each_segment_all(bvec, bio, i) + bio_for_each_segment_all(bvec, bio, i) { SetPageError(bvec->bv_page); - set_bit(AS_EIO, &io->op.inode->v.i_mapping->flags); + mapping_set_error(bvec->bv_page->mapping, -EIO); + } } /* @@ -2079,10 +2080,9 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync) if (ret) return ret; out: - if (c->opts.journal_flush_disabled) - return 0; - - ret = bch2_journal_flush_seq(&c->journal, inode->ei_journal_seq); + if (!c->opts.journal_flush_disabled) + ret = bch2_journal_flush_seq(&c->journal, + inode->ei_journal_seq); ret2 = file_check_and_advance_wb_err(file); return ret ?: ret2; |