summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2019-07-18 17:32:20 -0400
committerKent Overstreet <kent.overstreet@gmail.com>2019-08-09 16:41:07 -0400
commitaeec11b96230667ba4d2efe1eabe519ea2fd07be (patch)
tree85f523a9513921175ef755bf7ab081a25caac0db
parente095efe97976f4248958a4cb1e8a9e002b3f821b (diff)
bcachefs: Don't unlink iters on unsuccessful commit
Where unlink_on_commit is used, on unsuccessfull commit we're likely retrying the whole update and were going to be using the same iterators again. The management of multiple iterators needs to be gone over a fair bit more at some point... Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
-rw-r--r--fs/bcachefs/btree_update_leaf.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c
index 4f12108bd6fe..bb4002dda0cd 100644
--- a/fs/bcachefs/btree_update_leaf.c
+++ b/fs/bcachefs/btree_update_leaf.c
@@ -923,8 +923,6 @@ out_noupdates:
bch2_trans_unlink_iters(trans, ~trans->iters_touched|
trans->iters_unlink_on_commit);
trans->iters_touched = 0;
- } else {
- bch2_trans_unlink_iters(trans, trans->iters_unlink_on_commit);
}
trans->nr_updates = 0;
trans->mem_top = 0;