diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2025-03-24 14:23:25 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2025-03-24 16:42:05 -0400 |
| commit | 673f13665aa63968acf0cb4770dace98b2b3bb26 (patch) | |
| tree | 0f8a071ba6be6e6b78c64c68935ef079668f38a5 | |
| parent | 127d90d2823ef45dd37246aaf7bb0392e6231c38 (diff) | |
bcachefs: checksum check in data_update_read_done DEBUG
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/data_update.c | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/fs/bcachefs/data_update.c b/fs/bcachefs/data_update.c index 08bb7f3019ce..f2d30e7354a1 100644 --- a/fs/bcachefs/data_update.c +++ b/fs/bcachefs/data_update.c @@ -431,6 +431,8 @@ int bch2_data_update_index_update(struct bch_write_op *op) void bch2_data_update_read_done(struct data_update *m) { + struct bch_fs *c = m->op.c; + m->read_done = true; /* write bio must own pages: */ @@ -439,7 +441,26 @@ void bch2_data_update_read_done(struct data_update *m) m->op.crc = m->rbio.pick.crc; m->op.wbio.bio.bi_iter.bi_size = m->op.crc.compressed_size << 9; - this_cpu_add(m->op.c->counters[BCH_COUNTER_io_move_write], m->k.k->k.size); + struct nonce nonce = extent_nonce(m->op.version, m->op.crc); + struct bch_csum csum = bch2_checksum_bio(c, m->op.crc.csum_type, nonce, &m->op.wbio.bio); + if (bch2_crc_cmp(m->op.crc.csum, csum) && !c->opts.no_data_io) { + struct printbuf buf = PRINTBUF; + prt_printf(&buf, "checksum error in %s() (memory corruption or bug?)\n" + " expected %0llx:%0llx got %0llx:%0llx type ", + __func__, + m->op.crc.csum.hi, + m->op.crc.csum.lo, + csum.hi, + csum.lo); + bch2_prt_csum_type(&buf, m->op.crc.csum_type); + WARN_RATELIMIT(1, "%s", buf.buf); + printbuf_exit(&buf); + + m->op.end_io(&m->op); + return; + } + + this_cpu_add(c->counters[BCH_COUNTER_io_move_write], m->k.k->k.size); closure_call(&m->op.cl, bch2_write, NULL, NULL); } |