diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-05-11 12:52:48 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@gmail.com> | 2022-06-19 15:25:57 -0400 |
| commit | 4503fcca923a9f249c7e734d689e7b8455d77fc5 (patch) | |
| tree | b5393298b4f2d9f7f1b4821928f839efd52c3e23 | |
| parent | bef7a233daa70971bbc9361390c5b47db3d10dbe (diff) | |
test_printf: Drop requirement that sprintf not write past nul
The current test code checks that sprintf never writes past the
terminating nul. This is a rather strange requirement, completely
separate from writing past the end of the buffer, which of course we
can't do: writing anywhere to the buffer passed to snprintf, within size
of course, should be perfectly fine.
Since this check has no documentation as to where it comes from or what
depends on it, and it's getting in the way of further refactoring
(printf_spec handling is right now scattered massively throughout the
code, and we'd like to consolidate it) - delete it.
Also, many current pretty-printers building up their output on the
stack, and then copy it to the actual output buffer - by eliminating
this requirement we can kill those extra buffers.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
| -rw-r--r-- | lib/test_printf.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/lib/test_printf.c b/lib/test_printf.c index e3de52da9117..853e89e2f8c8 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -79,12 +79,6 @@ do_test(int bufsize, const char *expect, int elen, return 1; } - if (memchr_inv(test_buffer + written + 1, FILL_CHAR, BUF_SIZE + PAD_SIZE - (written + 1))) { - pr_warn("vsnprintf(buf, %d, \"%s\", ...) wrote beyond the nul-terminator\n", - bufsize, fmt); - return 1; - } - if (memcmp(test_buffer, expect, written)) { pr_warn("vsnprintf(buf, %d, \"%s\", ...) wrote '%s', expected '%.*s'\n", bufsize, fmt, test_buffer, written, expect); |