diff options
author | Kent Overstreet <kent.overstreet@gmail.com> | 2021-09-07 23:09:34 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@gmail.com> | 2021-09-08 14:49:38 -0400 |
commit | fc831fce0116733a999e2d16f1314d1908238fad (patch) | |
tree | 49d3586c5aafce7292a17ab98c9d9268456c96ce | |
parent | 71bee7fc888ed70371471ae374c332d8f76d10ab (diff) |
fixup! bcachefs: Drop some fast path tracepoints
-rw-r--r-- | fs/bcachefs/btree_iter.c | 25 | ||||
-rw-r--r-- | include/trace/events/bcachefs.h | 72 |
2 files changed, 1 insertions, 96 deletions
diff --git a/fs/bcachefs/btree_iter.c b/fs/bcachefs/btree_iter.c index 3b0c8895638c..ce4d7c7e6f9b 100644 --- a/fs/bcachefs/btree_iter.c +++ b/fs/bcachefs/btree_iter.c @@ -205,21 +205,8 @@ static inline bool btree_path_get_locks(struct btree_trans *trans, if (!(upgrade ? bch2_btree_node_upgrade(trans, path, l) - : bch2_btree_node_relock(trans, path, l))) { - (upgrade - ? trace_node_upgrade_fail - : trace_node_relock_fail)(trans->ip, trace_ip, - path->cached, - path->btree_id, &path->pos, - l, path->l[l].lock_seq, - is_btree_node(path, l) - ? 0 - : (unsigned long) path->l[l].b, - is_btree_node(path, l) - ? path->l[l].b->c.lock.state.seq - : 0); + : bch2_btree_node_relock(trans, path, l))) fail_idx = l; - } l++; } while (l < path->locks_want); @@ -410,16 +397,6 @@ bool bch2_btree_path_relock_intent(struct btree_trans *trans, l < path->locks_want && btree_path_node(path, l); l++) { if (!bch2_btree_node_relock(trans, path, l)) { - trace_node_relock_fail(trans->ip, _RET_IP_, - path->cached, - path->btree_id, &path->pos, - l, path->l[l].lock_seq, - is_btree_node(path, l) - ? 0 - : (unsigned long) path->l[l].b, - is_btree_node(path, l) - ? path->l[l].b->c.lock.state.seq - : 0); __bch2_btree_path_unlock(path); btree_path_set_dirty(path, BTREE_ITER_NEED_TRAVERSE); btree_trans_restart(trans); diff --git a/include/trace/events/bcachefs.h b/include/trace/events/bcachefs.h index 1b4b2092caa6..fce3146378f9 100644 --- a/include/trace/events/bcachefs.h +++ b/include/trace/events/bcachefs.h @@ -794,78 +794,6 @@ TRACE_EVENT(trans_restart_mem_realloced, __entry->bytes) ); -DECLARE_EVENT_CLASS(node_lock_fail, - TP_PROTO(unsigned long trans_ip, - unsigned long caller_ip, - bool key_cache, - enum btree_id btree_id, - struct bpos *pos, - unsigned level, u32 iter_seq, unsigned node, u32 node_seq), - TP_ARGS(trans_ip, caller_ip, key_cache, btree_id, pos, - level, iter_seq, node, node_seq), - - TP_STRUCT__entry( - __field(unsigned long, trans_ip ) - __field(unsigned long, caller_ip ) - __field(u8, key_cache ) - __field(u8, btree_id ) - __field(u64, pos_inode ) - __field(u64, pos_offset ) - __field(u32, pos_snapshot ) - __field(u32, level ) - __field(u32, iter_seq ) - __field(u32, node ) - __field(u32, node_seq ) - ), - - TP_fast_assign( - __entry->trans_ip = trans_ip; - __entry->caller_ip = caller_ip; - __entry->key_cache = key_cache; - __entry->btree_id = btree_id; - __entry->pos_inode = pos->inode; - __entry->pos_offset = pos->offset; - __entry->pos_snapshot = pos->snapshot; - __entry->level = level; - __entry->iter_seq = iter_seq; - __entry->node = node; - __entry->node_seq = node_seq; - ), - - TP_printk("%ps %pS key cache %u btree %u pos %llu:%llu:%u level %u iter seq %u node %u node seq %u", - (void *) __entry->trans_ip, - (void *) __entry->caller_ip, - __entry->key_cache, - __entry->btree_id, - __entry->pos_inode, - __entry->pos_offset, - __entry->pos_snapshot, - __entry->level, __entry->iter_seq, - __entry->node, __entry->node_seq) -); - -DEFINE_EVENT(node_lock_fail, node_upgrade_fail, - TP_PROTO(unsigned long trans_ip, - unsigned long caller_ip, - bool key_cache, - enum btree_id btree_id, - struct bpos *pos, - unsigned level, u32 iter_seq, unsigned node, u32 node_seq), - TP_ARGS(trans_ip, caller_ip, key_cache, btree_id, pos, - level, iter_seq, node, node_seq) -); - -DEFINE_EVENT(node_lock_fail, node_relock_fail, - TP_PROTO(unsigned long trans_ip, - unsigned long caller_ip, - bool key_cache, - enum btree_id btree_id, - struct bpos *pos, - unsigned level, u32 iter_seq, unsigned node, u32 node_seq), - TP_ARGS(trans_ip, caller_ip, key_cache, btree_id, pos, - level, iter_seq, node, node_seq) -); - #endif /* _TRACE_BCACHE_H */ /* This part must be outside protection */ |