1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
|
#include <tools/ccanlint/ccanlint.h>
#include <tools/tools.h>
#include <ccan/str/str.h>
#include <ccan/take/take.h>
#include <ccan/foreach/foreach.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <limits.h>
#include <errno.h>
#include <stdlib.h>
#include <stdio.h>
#include <err.h>
#include <string.h>
#include <ctype.h>
static bool has_dep(struct manifest *m, char **deps, bool *used,
const char *depname)
{
unsigned int i;
/* We can include ourselves, of course. */
if (streq(depname + strlen("ccan/"), m->modname))
return true;
for (i = 0; deps[i]; i++) {
if (streq(deps[i], depname)) {
used[i] = true;
return true;
}
}
return false;
}
static bool check_dep_includes(struct manifest *m,
char **deps, bool *used,
struct score *score,
struct ccan_file *f)
{
unsigned int i;
char **lines = get_ccan_file_lines(f);
struct line_info *li = get_ccan_line_info(f);
bool ok = true;
for (i = 0; lines[i]; i++) {
char *mod;
if (!tal_strreg(f, lines[i],
"^[ \t]*#[ \t]*include[ \t]*[<\"]"
"(ccan/+.+)/+[^/]+\\.h", &mod))
continue;
if (has_dep(m, deps, used, mod))
continue;
/* FIXME: we can't be sure about conditional includes,
* so don't complain (handle common case of idempotent wrap) */
if (!li[i].cond || li[i].cond == f->idempotent_cond) {
score_file_error(score, f, i+1,
"%s not listed in _info", mod);
ok = false;
}
}
return ok;
}
static void check_depends_accurate(struct manifest *m,
unsigned int *timeleft, struct score *score)
{
struct list_head *list;
unsigned int i, core_deps, test_deps;
char **deps, **tdeps;
bool *used;
bool ok = true;
/* Get the *direct* dependencies. */
if (safe_mode) {
deps = get_safe_ccan_deps(m, m->dir, "depends", false);
tdeps = get_safe_ccan_deps(m, m->dir, "testdepends", false);
} else {
deps = get_deps(m, m->dir, "depends", false,
get_or_compile_info);
tdeps = get_deps(m, m->dir, "testdepends", false,
get_or_compile_info);
}
core_deps = tal_count(deps) - 1;
test_deps = tal_count(tdeps) - 1;
used = tal_arrz(m, bool, core_deps + test_deps + 1);
foreach_ptr(list, &m->c_files, &m->h_files) {
struct ccan_file *f;
list_for_each(list, f, list)
ok &= check_dep_includes(m, deps, used, score, f);
}
for (i = 0; i < core_deps; i++) {
if (!used[i] && strstarts(deps[i], "ccan/"))
score_file_error(score, m->info_file, 0,
"%s is an unused dependency",
deps[i]);
}
/* Now remove NUL and append test dependencies to deps. */
deps = tal_dup_arr(m, char *, take(deps), core_deps, test_deps + 2);
memcpy(deps + core_deps, tdeps, sizeof(tdeps[0]) * test_deps);
/* ccan/tap is given a free pass. */
deps[core_deps + test_deps] = (char *)"ccan/tap";
deps[core_deps + test_deps + 1] = NULL;
foreach_ptr(list, &m->run_tests, &m->api_tests,
&m->compile_ok_tests, &m->compile_fail_tests,
&m->other_test_c_files) {
struct ccan_file *f;
list_for_each(list, f, list)
ok &= check_dep_includes(m, deps, used, score, f);
}
for (i = core_deps; i < test_deps; i++) {
if (!used[i])
score_file_error(score, m->info_file, 0,
"%s is an unused test dependency",
deps[i]);
}
if (!score->error)
score->score = score->total;
/* We don't count unused dependencies as an error (yet!) */
score->pass = ok;
}
struct ccanlint depends_accurate = {
.key = "depends_accurate",
.name = "Module's CCAN dependencies are the only CCAN files #included",
.check = check_depends_accurate,
.needs = "depends_exist test_depends_exist headers_idempotent"
};
REGISTER_TEST(depends_accurate);
|
