summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHoan Tran <hotran@apm.com>2016-10-10 10:13:10 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-10 16:38:44 +0100
commit0fda1cdcbb726bd78cd38f4e323cd37ef63145b7 (patch)
tree654a2fe4314f4f5279a8ec31d583574864b9dbc0
parent9c619c2a8d4d14c7e9fe741239b7b42f610f09d9 (diff)
i2c: xgene: Avoid dma_buffer overrun
commit 603616017c35f4d0fbdbcace72adf9bf949c4a65 upstream. SMBus block command uses the first byte of buffer for the data length. The dma_buffer should be increased by 1 to avoid the overrun issue. Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org> Signed-off-by: Hoan Tran <hotran@apm.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/i2c/busses/i2c-xgene-slimpro.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 4233f5695352..3c38029e3fe9 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -105,7 +105,7 @@ struct slimpro_i2c_dev {
struct mbox_chan *mbox_chan;
struct mbox_client mbox_client;
struct completion rd_complete;
- u8 dma_buffer[I2C_SMBUS_BLOCK_MAX];
+ u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */
u32 *resp_msg;
};