summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-22Enable --rustfmt-bindings by defaultHarlan Haskins
This patch flips --rustfmt-bindings to --no-rustfmt-bindings and enables formatting by default. If rustfmt is not accessible, a warning is printed and the bindings are printed unformatted.
2017-09-22Auto merge of #1016 - pepyakin:impl-debug-fixes, r=fitzgenbors-servo
Impl_debug fixes r? @fitzgen
2017-09-22Auto merge of #1014 - pepyakin:generate-base-names, r=fitzgenbors-servo
Generate base names upon construction As per https://github.com/rust-lang-nursery/rust-bindgen/pull/1012#discussion_r140378893 r? @fitzgen
2017-09-22Create an FAQ section in the bookNick Fitzgerald
I feel like we've had to anwer these questions multiple times... Good to be able to just point people to these canonical answers instead of repeating ourselves.
2017-09-22Fix condition in command_line_flags for impl_debugSergey Pepyakin
2017-09-22Rename derive_debug → impl_debug.Sergey Pepyakin
2017-09-22Generate base names upon constructon.Sergey Pepyakin
2017-09-21Auto merge of #1010 - pepyakin:add-chat-in-readme, r=fitzgenbors-servo
Add links to `impl period` blog post and gitter.im r? @fitzgen
2017-09-21Auto merge of #1008 - AndrewGaspar:underscore-identifier, r=fitzgenbors-servo
Translate _ as __ This change treats _ as a reserved identifier to resolve the bug reported in #631. I have one concern - if the header has both an `_` and `__` identifier in the global namespace, this will cause a conflict. However, it seems like we already don't handle that case for `keyword_` (e.g. `abstract_`, `alignof_`, etc.) so it doesn't seem like we need a solution specifically for `__` in this change. Fixes #631.
2017-09-21Add links to `impl period` blog post and gitter.imSergey Pepyakin
2017-09-20Translate _ as __Andrew Gaspar
2017-09-20Clean up comments about the `Can[Trivially]Derive*` traitsNick Fitzgerald
The whole "should be a no-op" thing isn't really true for all of the traits, especially in the face of black listing. Also further expounded on the differences between the trivial versions and normal versions.
2017-09-20Common method for whether function pointers can trivially derive traitsNick Fitzgerald
Again, this logic was getting copied all over the place, and it is nice to have a single canonical definition.
2017-09-20Factor array size vs Rust derive limit checking into a common methodNick Fitzgerald
We were copying it around and it will be easier if it is defined in one place.
2017-09-20Clean up some derive-related commentsNick Fitzgerald
Changing "partialeq" and "partialord" into "`PartialEq`" and "`PartialOrd`" where it makes sense.
2017-09-20Auto merge of #1001 - aeleos:master, r=fitzgenbors-servo
Ensure all derive analyses check array limit on bitfields Fixes #982 r? @fitzgen
2017-09-19Add large bitfield derive test and fix missing limitOliver Geller
2017-09-19Ensure all derive analyses check array limit on bitfieldsOliver Geller
2017-09-19Auto merge of #996 - alexeyzab:add-no-partialeq-command, r=fitzgenbors-servo
Add --no-partialeq <regex> flag Related to #965. - [x] Add a new RegexSet member to bindgen::Builder (similar to the whitelisted_types set). - [x] A Builder method to add strings to that RegexSet. - [x] Plumbing in src/options.rs to convert --no-partialeq <regex> CLI flags into invocations of the builder method. - [x] Make the MonotoneFramework::constrain function in src/ir/analysis/derive_partialeq.rs check if the given item is explicitly marked not to be Partialeq, and if so, insert it into the self.cannot_derive_partialeq set via return self.insert(id). - [x] Tests! - [x] When the no-partialeq type is transitively referenced by a whitelisted item - [x] When the no-partialeq type is explicitly whitelisted - [x] When the no-partialeq type is marked opaque This is my first pass at implementing this functionality, I haven't implemented the tests yet. I wanted to make sure I am on the right track, particularly when it comes to updating `MonotoneFramework::constrain`. r? @fitzgen
2017-09-19Add --no-partialeq <regex> flagAlexey Zabelin
- [x] Add a new RegexSet member to bindgen::Builder (similar to the whitelisted_types set). - [x] A Builder method to add strings to that RegexSet. - [x] Plumbing in src/options.rs to convert --no-partialeq <regex> CLI flags into invocations of the builder method. - [x] Make the MonotoneFramework::constrain function in src/ir/analysis/derive_partialeq.rs check if the given item is explicitly marked not to be Partialeq, and if so, insert it into the self.cannot_derive_partialeq set via return self.insert(id). - [x] Tests! - [x] When the no-partialeq type is transitively referenced by a whitelisted item - [x] When the no-partialeq type is explicitly whitelisted - [x] When the no-partialeq type is marked opaque Fixes #965
2017-09-19Auto merge of #1003 - pepyakin:derive-ord-when-possible, r=fitzgenbors-servo
Derive ord when possible Fixes #884 r? @fitzgen
2017-09-19Fix panic on has_float None unwrapSergey Pepyakin
2017-09-19Clean.Sergey Pepyakin
2017-09-19Add --with-derive-ord to some testsSergey Pepyakin
2017-09-19Derive Ord when possibleSergey Pepyakin
2017-09-19Auto merge of #1002 - pepyakin:derive-partialord-when-possible, r=fitzgenbors-servo
Derive PartialOrd when possible Fixes #882 r? @fitzgen
2017-09-19Add --with-derive-partialord for some testsSergey Pepyakin
2017-09-19Rename deriver_partial_eq_or_partial_ord.Sergey Pepyakin
2017-09-19Emit derive(PartialOrd)Sergey Pepyakin
2017-09-19derive_partialord in BindgenOptions and BuilderSergey Pepyakin
2017-09-19DerivePartialEq → DerivePartialEqOrPartialOrdSergey Pepyakin
2017-09-18Auto merge of #1000 - pepyakin:hide-bindgen-options, r=fitzgenbors-servo
Make BindgenOptions private Fixes https://github.com/rust-lang-nursery/rust-bindgen/issues/958 r? @fitzgen
2017-09-18Make BindgenOptions privateSergey Pepyakin
2017-09-15Auto merge of #994 - treiff:depreciate-builder-whitelist-type, r=fitzgenbors-servo
Depreciate `Builder::whitelisted_type`. Closes #987 Also, we were making a call to the now deprecated `Builder::hide_type`, changed that over to call `Builder::blacklist_type.
2017-09-15Fix whitelisting documentation links in book.Trevor Reiff
Update to reference `whitelist_type` function.
2017-09-15Depreciate `Builder::whitelisted_type`.Trevor Reiff
Closes #987 Also, we were making a call to the now deprecated `Builder::hide_type`, changed that over to call `Builder::blacklist_type.
2017-09-14Auto merge of #991 - alexeyzab:add-builder-blacklist-type, r=fitzgenbors-servo
Add a `Builder::blacklist_type` This deprecates `Builder::hide_type`. Related to #984. - [x] Add Builder::blacklist_type, that does the same thing as hide_type - [x] Mark Builder::hide_type as #[deprecated = "Use blacklist_type instead"] - [x] Make hide_type delegate to blacklist_type - [x] Rename the BindgenOptions::hidden_types member to BindgenOptions::blacklisted_types - [x] Rename ir::context::BindgenContext::hidden_by_name to blacklisted_by_name - [x] Rename ir::item::Item::is_hidden to is_blacklisted r? @fitzgen
2017-09-14Auto merge of #990 - treiff:depreciate-whitelisted-function, r=fitzgenbors-servo
Depreciate whitelisted function. Closes #985 I also noticed a reference to `whitelisted_function` within the book, should this be updated as well? https://github.com/rust-lang-nursery/rust-bindgen/blob/a371de097f5e37eb01754525fb1e2029ca88b0be/book/src/whitelisting.md I've started to learn rust recently, so please let me know if there is anything I missed.
2017-09-14Add a `Builder::blacklist_type`Alexey Zabelin
This deprecates `Builder::hide_type`. Related to #984. - [x] Add Builder::blacklist_type, that does the same thing as hide_type - [x] Mark Builder::hide_type as #[deprecated = "Use blacklist_type instead"] - [x] Make hide_type delegate to blacklist_type - [x] Rename the BindgenOptions::hidden_types member to BindgenOptions::blacklisted_types - [x] Rename ir::context::BindgenContext::hidden_by_name to blacklisted_by_name - [x] Rename ir::item::Item::is_hidden to is_blacklisted
2017-09-14Depreciate whitelisted function.Trevor Reiff
Closes #985
2017-09-14Auto merge of #989 - aeleos:master, r=fitzgenbors-servo
Make whitelisted_var consistant with CLI flags Closes #986 This is my first time contributing to rust so hopefully I did everything right, otherwise let me know.
2017-09-13Make whitelisted_var consistant with CLI flagsOliver Geller
2017-09-13Auto merge of #988 - fitzgen:overview, r=emiliobors-servo
Add an architectural overview of `bindgen` to CONTRIBUTING.md This should help new contributors who are coming to the code base for the first time get up and running. r? @emilio
2017-09-13Add an architectural overview of `bindgen` to CONTRIBUTING.mdNick Fitzgerald
This should help new contributors who are coming to the code base for the first time get up and running.
2017-09-11Auto merge of #976 - Cldfire:default-to-constified-enums, r=fitzgenbors-servo
Generate constants for enums by default Closes #758. The first commit does strictly what the issue description described, the second does a small amount of (what I believe is) logic simplification. Hopefully I didn't miss any tests when adding the `--rustified-enum .*` flag to the ones that needed it; all of the tests are passing for me, though, so I don't think I did.
2017-09-11Make bindgen generate enums as constants by defaultCldfire
Also simplifies the logic that determines which enum variation gets chosen.
2017-09-08Auto merge of #973 - fitzgen:help-wanted, r=fitzgenbors-servo
Add a link to issues labeled "help wanted" to CONTRIBUTING.md
2017-09-08Add a link to issues labeled "help wanted" to CONTRIBUTING.mdNick Fitzgerald
2017-09-07Auto merge of #956 - ↵bors-servo
fitzgen:document-no-recursive-whitelist-will-break-code, r=emilio Document that not recursively whitelisting is dangerous See #949 for context and motivation. r? @emilio
2017-09-07Auto merge of #940 - fitzgen:no-syntex, r=emiliobors-servo
No more syntex There are a few commits in this PR, but the big one is the commit that goes `syntex` -> `quote` for code generation. I've included a copy of its commit message below. I tried to verify that it works with the stylo build still, but there were some issues, and then I checked with master, and that wasn't working either. So now I'm C-Reducing the failures on master and figured that this is at least ready for feedback in the meantime. r? @emilio ---------------------------- The `syntex` crate is unmaintained. It is slow to build, and additionally it requires that we pre-process `src/codegen/mod.rs` before we build the `bindgen` crate. The `quote` crate provides similar quasi-quoting functionality, is maintained, and builds faster. It doesn't have a typed API or builders, however; it only deals with tokens. Before this commit: ``` $ cargo clean; cargo build <snip> Finished dev [unoptimized + debuginfo] target(s) in 98.75 secs ``` After this commit: ``` $ cargo clean; cargo build <snip> Finished dev [unoptimized + debuginfo] target(s) in 46.26 secs ``` Build time is cut in half! But what about run time? Before this commit: ``` Generated Stylo bindings in: Duration { secs: 3, nanos: 521105668 } ``` After this commit: ``` Generated Stylo bindings in: Duration { secs: 3, nanos: 548797242 } ``` So it appears to be about 20ms slower at generating Stylo bindings, but I suspect this is well within the noise. Finally, this also lets us remove that nasty `mem::transmute` inside `bindgen::ir::BindgenContext::gen` that was used for the old `syntex` context. Now `BindgenContext` doesn't have a lifetime parameter either. This should make it easier to revisit doing our analyses in parallel with `rayon`, since that context was one of the things that made it hard for `BindgenContext` to implement `Sync`. Fixes #925
generated by cgit v1.2.3 (git 2.46.0) at 2025-07-31 10:13:03 +0000