From 5229dc2f1dba07673138b2bafd40f3ea022fa0ba Mon Sep 17 00:00:00 2001 From: Nick Fitzgerald Date: Fri, 20 Jan 2017 14:14:23 -0800 Subject: Document why we shouldn't be tracing module -> child edges --- src/ir/item.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ir/item.rs b/src/ir/item.rs index df8fd222..ac2d122e 100644 --- a/src/ir/item.rs +++ b/src/ir/item.rs @@ -205,7 +205,12 @@ impl TypeCollector for Item { ItemKind::Var(ref var) => { types.insert(var.ty()); } - _ => {} // FIXME. + ItemKind::Module(_) => { + // Module -> children edges are "weak", and we do not want to + // trace them. If we did, then whitelisting wouldn't work as + // expected: everything in every module would end up + // whitelisted. + } } } } -- cgit v1.2.3