From fa1245198a0c61c13c0a8e6e02d431efe25ba0c9 Mon Sep 17 00:00:00 2001 From: Emilio Cobos Álvarez Date: Sat, 31 Mar 2018 15:30:19 +0200 Subject: codegen: Don't skip alignment checks if we support repr align. Plus fix the check that avoids us generating explicit alignment fields for structs aligned to more than pointer-size. Fixes #1291 --- src/codegen/struct_layout.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'src/codegen/struct_layout.rs') diff --git a/src/codegen/struct_layout.rs b/src/codegen/struct_layout.rs index d2be5aff..3a641f4a 100644 --- a/src/codegen/struct_layout.rs +++ b/src/codegen/struct_layout.rs @@ -286,8 +286,18 @@ impl<'a> StructLayoutTracker<'a> { } pub fn requires_explicit_align(&self, layout: Layout) -> bool { - self.max_field_align < layout.align && - layout.align <= self.ctx.target_pointer_size() + if self.max_field_align >= layout.align { + return false; + } + // At this point we require explicit alignment, but we may not be able + // to generate the right bits, let's double check. + if self.ctx.options().rust_features().repr_align { + return true; + } + + // We can only generate up-to a word of alignment unless we support + // repr(align). + layout.align <= self.ctx.target_pointer_size() } fn padding_bytes(&self, layout: Layout) -> usize { -- cgit v1.2.3