From da3f3a3ab13fb335b525d74a38e6a8634a117fe5 Mon Sep 17 00:00:00 2001 From: Adrian Taylor Date: Sun, 3 Oct 2021 09:35:10 -0700 Subject: Avoid case of a self-referential type alias. This previously produced a type alias which referred to itself, which was clearly wrong and resulted in downstream code recursing infinitely. The problem case (per bug #2102) is: template class B{}; template class C { public: using U = B; }; class A : C { U u; }; As far as I can tell, we parse clang's definition of B; that leads us to parse A; to find it has a field U which turns out to be of type B. And so we hit the line in item.rs which says: debug!("Avoiding recursion parsing type: {:?}", ty); and bail out, returning the original item ID: hence, a self- referential typedef is created. The 'fix' in this PR creates an opaque type in this case instead, to avoid later infinite loops. It would be preferable to avoid this situation in the first place, but presumably that would require us to split the parsing phase into two: 1) types 2) fields within those types. Fixes #2102. --- tests/headers/constified-enum-module-overflow.hpp | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tests/headers/constified-enum-module-overflow.hpp (limited to 'tests/headers/constified-enum-module-overflow.hpp') diff --git a/tests/headers/constified-enum-module-overflow.hpp b/tests/headers/constified-enum-module-overflow.hpp new file mode 100644 index 00000000..d48f2be1 --- /dev/null +++ b/tests/headers/constified-enum-module-overflow.hpp @@ -0,0 +1,8 @@ +template class B{}; +template class C { +public: + using U = B; +}; +class A : C { + U u; +}; -- cgit v1.2.3