diff options
| author | Jeff Layton <jlayton@kernel.org> | 2023-08-30 06:58:50 -0400 |
|---|---|---|
| committer | Zorro Lang <zlang@kernel.org> | 2023-09-02 13:54:38 +0800 |
| commit | 6bf1570d33ccba99507dcfc96c2ddd23723f8568 (patch) | |
| tree | 8e9b9fd8c73bb09bebb77e5bd8a311cad7b02763 | |
| parent | 7a2663730e69799dd1f29a345b3be256b53f9120 (diff) | |
common/attr: fix the _require_acl test
_require_acl tests whether you're able to fetch the ACL from a file
using chacl, and then tests for an -EOPNOTSUPP error return.
Unfortunately, filesystems that don't support them (like NFSv4) just
return -ENODATA when someone calls getxattr for the POSIX ACL, so the
test doesn't work.
Fix the test to have chacl set an ACL on the file instead, which should
reliably fail on filesystems that don't support them.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
| -rw-r--r-- | common/attr | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/common/attr b/common/attr index cce4d1b2..3ebba682 100644 --- a/common/attr +++ b/common/attr @@ -163,13 +163,12 @@ _require_acls() [ -n "$CHACL_PROG" ] || _notrun "chacl command not found" # - # Test if chacl is able to list ACLs on the target filesystems. On really - # old kernels the system calls might not be implemented at all, but the - # more common case is that the tested filesystem simply doesn't support - # ACLs. + # Test if chacl is able to set an ACL on a file. On really old kernels + # the system calls might not be implemented at all, but the more common + # case is that the tested filesystem simply doesn't support ACLs. # touch $TEST_DIR/syscalltest - chacl -l $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1 + chacl 'u::rw-,g::---,o::---' $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1 cat $TEST_DIR/syscalltest.out >> $seqres.full if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then |