diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2024-02-01 21:01:02 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-02-05 01:16:31 -0500 |
| commit | 7b508b323b2ec45be59769bd4e4aeba729c52cf6 (patch) | |
| tree | bc6794a2bd18458cc54f7f0eeea0ecfb512af437 | |
| parent | dd839f31d7cd5e04f4111a219024268c6f6973f0 (diff) | |
bcachefs: time_stats: Check for last_event == 0 when updating freq statsbcachefs-2024-02-05
This fixes spurious outliers in the frequency stats.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/util.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c index 56b815fd9fc6..231003b405ef 100644 --- a/fs/bcachefs/util.c +++ b/fs/bcachefs/util.c @@ -418,14 +418,15 @@ static inline void bch2_time_stats_update_one(struct bch2_time_stats *stats, bch2_quantiles_update(&stats->quantiles, duration); } - if (time_after64(end, stats->last_event)) { + if (stats->last_event && time_after64(end, stats->last_event)) { freq = end - stats->last_event; mean_and_variance_update(&stats->freq_stats, freq); mean_and_variance_weighted_update(&stats->freq_stats_weighted, freq); stats->max_freq = max(stats->max_freq, freq); stats->min_freq = min(stats->min_freq, freq); - stats->last_event = end; } + + stats->last_event = end; } static void __bch2_time_stats_clear_buffer(struct bch2_time_stats *stats, |