summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2023-09-13 18:44:09 +0200
committerKent Overstreet <kent.overstreet@linux.dev>2023-09-13 20:02:29 -0400
commit5584c903a9ea205037eaf4672e830fbe164888b2 (patch)
treef371e36a942acd1423360bfe31cb77798c3a2dd9
parentf1a434f7c8afee8d3bf9cd8c62b87445536d84c2 (diff)
bcachefs: Remove a redundant and harmless bch2_free_super() call
Remove a redundant call to bch2_free_super(). This is harmless because bch2_free_super() has a memset() at its end. So a second call would only lead to from kfree(NULL). Remove the redundant call and only rely on the error handling path. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
-rw-r--r--fs/bcachefs/super.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 9f852a6dd76a..2990eed85adf 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1605,7 +1605,6 @@ int bch2_dev_add(struct bch_fs *c, const char *path)
ca = __bch2_dev_alloc(c, &dev_mi);
if (!ca) {
- bch2_free_super(&sb);
ret = -ENOMEM;
goto err;
}