summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2023-09-14 12:47:44 +0300
committerKent Overstreet <kent.overstreet@linux.dev>2023-09-14 15:57:27 -0400
commitd7c26c06065b48b2f67ac6edb1cadae28b14d628 (patch)
tree9300a78049d67b9c74f3836a086cf4f5cd0a98b1
parent3567a5dc61abed9924051091e201b5a7b718b8ef (diff)
bcachefs: fix error checking in bch2_fs_alloc()
There is a typo here where it uses ";" instead of "?:". The result is that bch2_fs_fs_io_direct_init() is called unconditionally and the errors from it are not checked. Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> Reviewed-by: Brian Foster <bfoster@redhat.com>
-rw-r--r--fs/bcachefs/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 2990eed85adf..e94a63a22704 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -852,7 +852,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts)
bch2_fs_compress_init(c) ?:
bch2_fs_ec_init(c) ?:
bch2_fs_fsio_init(c) ?:
- bch2_fs_fs_io_buffered_init(c);
+ bch2_fs_fs_io_buffered_init(c) ?:
bch2_fs_fs_io_direct_init(c);
if (ret)
goto err;