summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Desaulniers <ndesaulniers@google.com>2023-09-19 13:38:31 -0700
committerKent Overstreet <kent.overstreet@linux.dev>2023-09-19 16:53:25 -0400
commitf56b5185e18d2b27750257b07cbb1e8ee9e0969c (patch)
tree667ecb2ac78079ccfd11bc0fc647d1de8c2ff92e
parentb45cc9b18b48bfc9f41a482a1b34a8ce6bb64648 (diff)
bcachefs: Fix -Wself-assign
Fixes the following observed error reported by Nathan on IRC. fs/bcachefs/io_misc.c:467:6: error: explicitly assigning value of variable of type 'int' to itself [-Werror,-Wself-assign] 467 | ret = ret; | ~~~ ^ ~~~ Reported-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
-rw-r--r--fs/bcachefs/io_misc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/bcachefs/io_misc.c b/fs/bcachefs/io_misc.c
index 668493bcfe36..32432bdddac4 100644
--- a/fs/bcachefs/io_misc.c
+++ b/fs/bcachefs/io_misc.c
@@ -462,9 +462,9 @@ btree_err:
bch2_logged_op_update(trans, &op->k_i));
}
- fallthrough;
+ break;
case LOGGED_OP_FINSERT_finish:
- ret = ret;
+ break;
}
err:
bch2_logged_op_finish(trans, op_k);