diff options
| author | Hunter Shaffer <huntershaffer182456@gmail.com> | 2023-08-29 18:05:09 -0400 |
|---|---|---|
| committer | Hunter Shaffer <huntershaffer182456@gmail.com> | 2023-10-08 21:06:07 -0400 |
| commit | 9f98746bfcd5159307237f7a491fd79db02d8bf3 (patch) | |
| tree | 10af18e18b44adf4cb8456d254aa5e2c44df9216 /tools-util.c | |
| parent | b2ffa12074f1a6060b715e0891c1efb3ee64be68 (diff) | |
Change open_for_format to the block io api
Upcoming patch will add device benchmarking at format time, which needs
the bio API.
Signed-off-by: Hunter Shaffer <huntershaffer182456@gmail.com>
Diffstat (limited to 'tools-util.c')
| -rw-r--r-- | tools-util.c | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/tools-util.c b/tools-util.c index 9b183735..f6e9a478 100644 --- a/tools-util.c +++ b/tools-util.c @@ -17,6 +17,7 @@ #include <blkid.h> #include <uuid/uuid.h> +#include "libbcachefs.h" #include "libbcachefs/bcachefs_ioctl.h" #include "linux/sort.h" #include "tools-util.h" @@ -212,22 +213,24 @@ unsigned get_blocksize(int fd) } /* Open a block device, do magic blkid stuff to probe for existing filesystems: */ -int open_for_format(const char *dev, bool force) +int open_for_format(struct dev_opts *dev, bool force) { blkid_probe pr; const char *fs_type = NULL, *fs_label = NULL; size_t fs_type_len, fs_label_len; - int fd = open(dev, O_RDWR|O_EXCL); - if (fd < 0) - die("Error opening device to format %s: %m", dev); + dev->bdev = blkdev_get_by_path(dev->path, BLK_OPEN_READ|BLK_OPEN_WRITE|BLK_OPEN_EXCL, + dev, NULL); + int ret = PTR_ERR_OR_ZERO(dev->bdev); + if (ret < 0) + die("Error opening device to format %s: %s", dev->path, strerror(-ret)); if (force) - return fd; + return 0; if (!(pr = blkid_new_probe())) die("blkid error 1"); - if (blkid_probe_set_device(pr, fd, 0, 0)) + if (blkid_probe_set_device(pr, dev->bdev->bd_buffered_fd, 0, 0)) die("blkid error 2"); if (blkid_probe_enable_partitions(pr, true)) die("blkid error 3"); @@ -240,19 +243,19 @@ int open_for_format(const char *dev, bool force) if (fs_type) { if (fs_label) printf("%s contains a %s filesystem labelled '%s'\n", - dev, fs_type, fs_label); + dev->path, fs_type, fs_label); else printf("%s contains a %s filesystem\n", - dev, fs_type); + dev->path, fs_type); fputs("Proceed anyway?", stdout); if (!ask_yn()) exit(EXIT_FAILURE); while (blkid_do_probe(pr) == 0) - blkid_do_wipe(pr, 0); + blkid_do_wipe(pr, 0); } blkid_free_probe(pr); - return fd; + return ret; } bool ask_yn(void) |