diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2025-04-15 12:53:05 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-04-16 18:26:42 -0700 |
| commit | 00868d0348187fe1123324f77e069a916f932037 (patch) | |
| tree | 32a9c8e54ea9596bd21bcd4baa861a545a1b64b2 | |
| parent | 4cc8b57753ef30650a5a326df0074d25f342aa84 (diff) | |
net: phy: mediatek: init val in .phy_led_polarity_set for AN7581
Fix smatch warning for uninitialised val in .phy_led_polarity_set for
AN7581 driver.
Correctly init to 0 to set polarity high by default.
Reported-by: Simon Horman <horms@kernel.org>
Fixes: 6a325aed130b ("net: phy: mediatek: add Airoha PHY ID to SoC driver")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: https://patch.msgid.link/20250415105313.3409-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/phy/mediatek/mtk-ge-soc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediatek/mtk-ge-soc.c index fd0e447ffce7..cd09684780a4 100644 --- a/drivers/net/phy/mediatek/mtk-ge-soc.c +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c @@ -1432,8 +1432,8 @@ static int an7581_phy_probe(struct phy_device *phydev) static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index, unsigned long modes) { + u16 val = 0; u32 mode; - u16 val; if (index >= MTK_PHY_MAX_LEDS) return -EINVAL; @@ -1444,7 +1444,6 @@ static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index, val = MTK_PHY_LED_ON_POLARITY; break; case PHY_LED_ACTIVE_HIGH: - val = 0; break; default: return -EINVAL; |