summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorImre Deak <imre.deak@intel.com>2024-12-12 01:03:25 +0200
committerImre Deak <imre.deak@intel.com>2024-12-17 16:03:56 +0200
commit04e10d00bf0a3e5bf07f6cdd44e296cf52407bf0 (patch)
tree1c1d7e5410086715d1b12d3b74ef555a81cb8019
parent5a83c9293ca0cac25055d4b804b2ebee700eba6f (diff)
drm/connector: Warn if a connector is registered/added incorrectly
All the drivers should be converted now to use drm_connector_dynamic_init() for MST connectors, hence drm_connector_dynamic_register()->drm_connector_add() can WARN now if this was not the case (for instance if a driver inited an MST connector with one of the drm_connector_init*() functions incorrectly). Reviewed-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Wayne Lin <Wayne.Lin@amd.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241211230328.4012496-9-imre.deak@intel.com
-rw-r--r--drivers/gpu/drm/drm_connector.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 3c6c0d7b9285..ae6e71305f30 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -331,11 +331,7 @@ static void drm_connector_add(struct drm_connector *connector)
struct drm_device *dev = connector->dev;
struct drm_mode_config *config = &dev->mode_config;
- /*
- * TODO: Change this to a WARN, once all drivers are converted to
- * call drm_connector_dynamic_init() for MST connectors.
- */
- if (!list_empty(&connector->head))
+ if (drm_WARN_ON(dev, !list_empty(&connector->head)))
return;
spin_lock_irq(&config->connector_list_lock);