diff options
| author | Harshad Shirwadkar <harshadshirwadkar@gmail.com> | 2025-05-08 17:59:02 +0000 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2025-05-08 21:56:17 -0400 |
| commit | 0b64fd74dd2054834c98867422bc9813e3bba8f4 (patch) | |
| tree | 9558b1db42af94185baac4fb0311a3f6b20b1ec4 | |
| parent | 4d3266463ed06af2916b306bdb0ebd647726ba49 (diff) | |
ext4: mark inode dirty before grabbing i_data_sem in ext4_setattr
Mark inode dirty first and then grab i_data_sem in ext4_setattr().
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://patch.msgid.link/20250508175908.1004880-4-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/inode.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index d58b99407390..3005053e92a7 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5568,9 +5568,7 @@ int ext4_setattr(struct mnt_idmap *idmap, struct dentry *dentry, down_write(&EXT4_I(inode)->i_data_sem); old_disksize = EXT4_I(inode)->i_disksize; EXT4_I(inode)->i_disksize = attr->ia_size; - rc = ext4_mark_inode_dirty(handle, inode); - if (!error) - error = rc; + /* * We have to update i_size under i_data_sem together * with i_disksize to avoid races with writeback code @@ -5581,6 +5579,9 @@ int ext4_setattr(struct mnt_idmap *idmap, struct dentry *dentry, else EXT4_I(inode)->i_disksize = old_disksize; up_write(&EXT4_I(inode)->i_data_sem); + rc = ext4_mark_inode_dirty(handle, inode); + if (!error) + error = rc; ext4_journal_stop(handle); if (error) goto out_mmap_sem; |