summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZichen Xie <zichenxie0106@gmail.com>2024-11-15 00:38:36 -0600
committerJohannes Berg <johannes.berg@intel.com>2024-12-04 16:11:11 +0100
commit13c4f7714c6a1ecf748a2f22099447c14fe6ed8c (patch)
treeb9dbf0fca4c028348b2d409f24fe773a0f7398d3
parent8e66f6c6738e5b458345cd5f75ef6da035d95599 (diff)
wifi: cfg80211: tests: Fix potential NULL dereference in test_cfg80211_parse_colocated_ap()
kunit_kzalloc() may return NULL, dereferencing it without NULL check may lead to NULL dereference. Add a NULL check for ies. Fixes: 45d43937a44c ("wifi: cfg80211: add a kunit test for 6 GHz colocated AP parsing") Signed-off-by: Zichen Xie <zichenxie0106@gmail.com> Link: https://patch.msgid.link/20241115063835.5888-1-zichenxie0106@gmail.com Signed-off-by: Johannes Berg <johannes.berg@intel.com>
-rw-r--r--net/wireless/tests/scan.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/wireless/tests/scan.c b/net/wireless/tests/scan.c
index 9f458be71659..79a99cf5e892 100644
--- a/net/wireless/tests/scan.c
+++ b/net/wireless/tests/scan.c
@@ -810,6 +810,8 @@ static void test_cfg80211_parse_colocated_ap(struct kunit *test)
skb_put_data(input, "123", 3);
ies = kunit_kzalloc(test, struct_size(ies, data, input->len), GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, ies);
+
ies->len = input->len;
memcpy(ies->data, input->data, input->len);