diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-05-05 17:20:41 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-02-01 20:40:30 -0500 |
| commit | 16a7ab38a93694e36190928c53ed3de6c244ce10 (patch) | |
| tree | e177738d9ba960c338b7308055c9588cf242b58e | |
| parent | d3bbcb66993fada2096b0ef36354de50437e4fc1 (diff) | |
bcachefs: Delete bch_writepage
Per Dave Chinner and the xfs folks, .writepage is no longer needed, and
it's better not to define it if .writepages is the intended path.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
| -rw-r--r-- | fs/bcachefs/fs-io.c | 14 | ||||
| -rw-r--r-- | fs/bcachefs/fs-io.h | 1 | ||||
| -rw-r--r-- | fs/bcachefs/fs.c | 1 |
3 files changed, 0 insertions, 16 deletions
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index cf2deed40707..47450809b118 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -1468,20 +1468,6 @@ int bch2_writepages(struct address_space *mapping, struct writeback_control *wbc return ret; } -int bch2_writepage(struct page *page, struct writeback_control *wbc) -{ - struct bch_fs *c = page->mapping->host->i_sb->s_fs_info; - struct bch_writepage_state w = - bch_writepage_state_init(c, to_bch_ei(page->mapping->host)); - int ret; - - ret = __bch2_writepage(page, wbc, &w); - if (w.io) - bch2_writepage_do_io(&w); - - return ret; -} - /* buffered writes: */ int bch2_write_begin(struct file *file, struct address_space *mapping, diff --git a/fs/bcachefs/fs-io.h b/fs/bcachefs/fs-io.h index 681ac710a008..a8835298613a 100644 --- a/fs/bcachefs/fs-io.h +++ b/fs/bcachefs/fs-io.h @@ -15,7 +15,6 @@ int __must_check bch2_write_inode_size(struct bch_fs *, struct bch_inode_info *, loff_t, unsigned); -int bch2_writepage(struct page *, struct writeback_control *); int bch2_read_folio(struct file *, struct folio *); int bch2_writepages(struct address_space *, struct writeback_control *); diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index c8e6e85fccb8..e9bcb6447041 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -1113,7 +1113,6 @@ static const struct inode_operations bch_special_inode_operations = { }; static const struct address_space_operations bch_address_space_operations = { - .writepage = bch2_writepage, .read_folio = bch2_read_folio, .writepages = bch2_writepages, .readahead = bch2_readahead, |