summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@gmail.com>2021-10-20 20:50:07 -0400
committerKent Overstreet <kent.overstreet@gmail.com>2021-12-30 17:56:29 -0500
commit403d514d6e9698064dfcfb291dadae4f6d4401f4 (patch)
tree10b226e30e3513b4c586a1adb237f61a0eae0f00
parent6c8e496df17678ca1d1bc7b7b394915ea55f97a8 (diff)
bcachefs: Delete dentry when deleting snapshots
This fixes a bug where subsequently doing creates with the same name fails. Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
-rw-r--r--fs/bcachefs/fs-ioctl.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
index 3ed53f420e7e..513f7a7a3fd4 100644
--- a/fs/bcachefs/fs-ioctl.c
+++ b/fs/bcachefs/fs-ioctl.c
@@ -422,6 +422,7 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp,
struct bch_ioctl_subvolume arg)
{
struct path path;
+ struct inode *dir;
int ret = 0;
if (arg.flags)
@@ -438,7 +439,13 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp,
return -EXDEV;
}
- ret = __bch2_unlink(path.dentry->d_parent->d_inode, path.dentry, 1);
+ dir = path.dentry->d_parent->d_inode;
+
+ ret = __bch2_unlink(dir, path.dentry, 1);
+ if (!ret) {
+ fsnotify_rmdir(dir, path.dentry);
+ d_delete(path.dentry);
+ }
path_put(&path);
return ret;