diff options
| author | NeilBrown <neilb@suse.de> | 2025-02-26 17:18:32 +1100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-02-26 09:55:18 +0100 |
| commit | 4cf006b739958942ee8b59b22c057681c65a9be6 (patch) | |
| tree | 95940b59924006fe8011a77e961f8b8c375cc383 | |
| parent | 3ff6c8707c9a0116d00982851ec1216a42053ace (diff) | |
nfsd: drop fh_update() from S_IFDIR branch of nfsd_create_locked()
nfsd_create_locked() doesn't need to explicitly call fh_update().
On success (which is the only time that fh_update() matters at all),
nfsd_create_setattr() will be called and it will call fh_update().
This extra call is not harmful, but is not necessary.
Signed-off-by: NeilBrown <neilb@suse.de>
Link: https://lore.kernel.org/r/20250226062135.2043651-3-neilb@suse.de
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/nfsd/vfs.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 29cb7b812d71..1035010f1198 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -1505,11 +1505,8 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, } dput(resfhp->fh_dentry); resfhp->fh_dentry = dget(d); - err = fh_update(resfhp); dput(dchild); dchild = d; - if (err) - goto out; } break; case S_IFCHR: |