diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2018-09-15 17:57:22 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@gmail.com> | 2019-04-03 12:43:22 -0400 |
| commit | 579a733ab87c839a06c355891e52a1fc91b171e0 (patch) | |
| tree | 7388ab3149b351f2f98e20dc8059285d2842d12c | |
| parent | cf610ac711e0e4f3bfe51c3851dfbbe2c28ee51c (diff) | |
bcachefs: Fix a deadlock
| -rw-r--r-- | fs/bcachefs/btree_update_interior.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c index 9828ad0fb7af..38503f8ffd9a 100644 --- a/fs/bcachefs/btree_update_interior.c +++ b/fs/bcachefs/btree_update_interior.c @@ -1549,7 +1549,13 @@ void bch2_btree_insert_node(struct btree_update *as, struct btree *b, btree_node_interior_verify(b); - bch2_foreground_maybe_merge(c, iter, b->level, flags); + /* + * when called from the btree_split path the new nodes aren't added to + * the btree iterator yet, so the merge path's unlock/wait/relock dance + * won't work: + */ + bch2_foreground_maybe_merge(c, iter, b->level, + flags|BTREE_INSERT_NOUNLOCK); return; split: btree_split(as, b, iter, keys, flags); |