diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2025-04-10 19:45:31 +0800 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-04-14 13:05:59 +0200 |
| commit | 698d1b483cd1c7126d61de8d155aceec50c04fb2 (patch) | |
| tree | 18edb53c5bbe22280e0ede27319c0b5ef1262b92 | |
| parent | 1d17057d2166a192b3fad358a20c93fa3e994ef8 (diff) | |
fs/fs_context: Mark an unlikely if condition with unlikely() in vfs_parse_monolithic_sep()
There is no mount option with pattern "...,=key_or_value,...", so the if
condition '(value == key)' in while loop of vfs_parse_monolithic_sep() is
is unlikely true.
Mark the condition with unlikely() to improve both performance and
readability.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/20250410-fix_fs-v1-5-7c14ccc8ebaa@quicinc.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/fs_context.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fs_context.c b/fs/fs_context.c index 2877d9dec075..666e61753aed 100644 --- a/fs/fs_context.c +++ b/fs/fs_context.c @@ -222,7 +222,7 @@ int vfs_parse_monolithic_sep(struct fs_context *fc, void *data, char *value = strchr(key, '='); if (value) { - if (value == key) + if (unlikely(value == key)) continue; *value++ = 0; v_len = strlen(value); |