diff options
| author | Chen Ni <nichen@iscas.ac.cn> | 2024-06-21 15:10:31 +0800 |
|---|---|---|
| committer | Maxime Ripard <mripard@kernel.org> | 2024-06-26 15:32:03 +0200 |
| commit | 7bd09a2db0f617377027a2bb0b9179e6959edff3 (patch) | |
| tree | d0e7cd1f861a53f26826cc3383a48dd9edab2f09 | |
| parent | 97370f8ed271405bab2af42b2d3abbb4002c9114 (diff) | |
drm/qxl: Add check for drm_cvt_mode
Add check for the return value of drm_cvt_mode() and return the error if
it fails in order to avoid NULL pointer dereference.
Fixes: 1b043677d4be ("drm/qxl: add qxl_add_mode helper function")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621071031.1987974-1-nichen@iscas.ac.cn
| -rw-r--r-- | drivers/gpu/drm/qxl/qxl_display.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index c6d35c33d5d6..86a5dea710c0 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -236,6 +236,9 @@ static int qxl_add_mode(struct drm_connector *connector, return 0; mode = drm_cvt_mode(dev, width, height, 60, false, false, false); + if (!mode) + return 0; + if (preferred) mode->type |= DRM_MODE_TYPE_PREFERRED; mode->hdisplay = width; |