diff options
| author | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2025-02-27 16:28:31 +0100 |
|---|---|---|
| committer | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2025-03-03 09:34:08 +0100 |
| commit | 8014097f1466f7e034844770c537b8dc7d98811f (patch) | |
| tree | e9443d2148fcc48625dd73d9e9081e435edde11d | |
| parent | cc76847bf3ec5db8051600da690b3bb6984cc854 (diff) | |
gpiolib: remove unneeded WARN_ON() from gpiochip_set_multiple()
GPIO drivers are not required to support set_multiple() - the core will
fallback to calling set() for each line if it's missing. Remove the
offending check from gpiochip_set_multiple().
Fixes: 98ce1eb1fd87 ("gpiolib: introduce gpio_chip setters that return values")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/all/ab3e42c0-70fa-48e0-ac93-ecbffef63507@samsung.com/
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250227152831.59784-1-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 212269f2d9a2..ec2217a30db3 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3604,9 +3604,6 @@ static int gpiochip_set_multiple(struct gpio_chip *gc, lockdep_assert_held(&gc->gpiodev->srcu); - if (WARN_ON(unlikely(!gc->set_multiple && !gc->set_multiple_rv))) - return -EOPNOTSUPP; - if (gc->set_multiple_rv) { ret = gc->set_multiple_rv(gc, mask, bits); if (ret > 0) |