diff options
| author | Ivan Abramov <i.abramov@mt-integration.ru> | 2025-03-10 17:04:06 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-03-24 09:45:07 -0500 |
| commit | 9fb2e20e4f6acade2807d35cea3318786866d08d (patch) | |
| tree | 6ac044c49266a7b97cca418633d9abebd4457fde | |
| parent | faf1b64888ff13caa94fa09835fcfdabee18b057 (diff) | |
smb: client: Remove redundant check in cifs_oplock_break()
There is an unnecessary NULL check of inode in cifs_oplock_break(), since
there are multiple dereferences of cinode prior to it.
Based on usage of cifs_oplock_break() in cifs_new_fileinfo() we can safely
assume that inode is not NULL, so there is no need to check inode in
cifs_oplock_break() at all.
Therefore, this redundant check can be removed.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Ivan Abramov <i.abramov@mt-integration.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index 8582cf61242c..66b775ae2f82 100644 --- a/fs/smb/client/file.c +++ b/fs/smb/client/file.c @@ -3082,7 +3082,7 @@ void cifs_oplock_break(struct work_struct *work) cinode->oplock = 0; } - if (inode && S_ISREG(inode->i_mode)) { + if (S_ISREG(inode->i_mode)) { if (CIFS_CACHE_READ(cinode)) break_lease(inode, O_RDONLY); else |