summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>2025-05-21 17:25:41 +0300
committerThomas Gleixner <tglx@linutronix.de>2025-05-21 17:48:23 +0200
commita510bb87da72aa8d1504b0e4b343cfe013ee8a89 (patch)
tree1802646b1acdf6904b72ad1da3e2ef7d4683b3d7
parent788019eb559fd0b365f501467ceafce540e377cc (diff)
genirq/irqdesc: Remove double locking in hwirq_show()
&desc->lock is acquired on 2 consecutive lines in hwirq_show(). This leads obviously to a deadlock. Drop the raw_spin_lock_irq() and keep guard(). Fixes: 5d964a9f7cd8 ("genirq/irqdesc: Switch to lock guards") Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/20250521142541.3832130-1-claudiu.beznea.uj@bp.renesas.com
-rw-r--r--kernel/irq/irqdesc.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 6d006a68ff85..b64c57b44c20 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -281,7 +281,6 @@ static ssize_t hwirq_show(struct kobject *kobj, struct kobj_attribute *attr, cha
struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
guard(raw_spinlock_irq)(&desc->lock);
- raw_spin_lock_irq(&desc->lock);
if (desc->irq_data.domain)
return sysfs_emit(buf, "%lu\n", desc->irq_data.hwirq);
return 0;