diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2024-07-27 16:34:01 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-07-31 14:55:49 +0200 |
| commit | bfa54a793ba77ef696755b66f3ac4ed00c7d1248 (patch) | |
| tree | cbbb1732b884220a22278ef6ce3d4b7fdd7a6002 | |
| parent | 2bdf3b83515ead3b3fdf93610e4a3bb9a89bc852 (diff) | |
driver core: bus: Fix double free in driver API bus_register()
For bus_register(), any error which happens after kset_register() will
cause that @priv are freed twice, fixed by setting @priv with NULL after
the first free.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240727-bus_register_fix-v1-1-fed8dd0dba7a@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/base/bus.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 5bb1dca96242..abf090ace833 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -922,6 +922,8 @@ bus_devices_fail: bus_remove_file(bus, &bus_attr_uevent); bus_uevent_fail: kset_unregister(&priv->subsys); + /* Above kset_unregister() will kfree @priv */ + priv = NULL; out: kfree(priv); return retval; |