diff options
| author | Janne Grunau <j@jannau.net> | 2025-02-26 19:00:06 +0000 |
|---|---|---|
| committer | Sven Peter <sven@svenpeter.dev> | 2025-02-28 21:36:45 +0000 |
| commit | e210227f0259d2666cc41b28ed1b7b0b0a99ed4d (patch) | |
| tree | 767a682c085a9aed3d4e6838f0d8bb4604d4f95b | |
| parent | 22af2fac88fa5dbc310bfe7d0b66d4de3ac47305 (diff) | |
soc: apple: rtkit: Cut syslog messages after the first '\0'
Certain messages from DCP contain NUL bytes in the random data after the
NUL terminated syslog message. Since the syslog message ends with '\n'
this results in a dev_info() message terminated with two newlines and an
empty printed line in the kernel log.
Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-4-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter <sven@svenpeter.dev>
| -rw-r--r-- | drivers/soc/apple/rtkit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c index 4b78463dd5a1..5fffd0f003dc 100644 --- a/drivers/soc/apple/rtkit.c +++ b/drivers/soc/apple/rtkit.c @@ -477,7 +477,7 @@ static void apple_rtkit_syslog_rx_log(struct apple_rtkit *rtk, u64 msg) log_context[sizeof(log_context) - 1] = 0; - msglen = rtk->syslog_msg_size - 1; + msglen = strnlen(rtk->syslog_msg_buffer, rtk->syslog_msg_size - 1); while (msglen > 0 && should_crop_syslog_char(rtk->syslog_msg_buffer[msglen - 1])) msglen--; |