summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWei Yongjun <weiyj.lk@gmail.com>2016-08-20 15:25:32 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-10-31 05:02:08 -0600
commit07f2b8ab7c38d1784733be864121efc70dc799a9 (patch)
tree553c1193bc974781a45a2dcd35a1628b64ad3744
parent16b127037a8fce38ca5022d8b0de6b695317667b (diff)
spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function
commit 6999aeabbb703a81a204cb6f9f8f151759a99ac4 upstream. The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is unnecessary and results in an access to free memory. Drop it. Fixes: 9298bc727385 ("spi: spi-fsl-dspi: Remove spi-bitbang") Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/spi/spi-fsl-dspi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 9e9dadb52b3d..eec5e3f6e06b 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -760,7 +760,6 @@ static int dspi_remove(struct platform_device *pdev)
/* Disconnect from the SPI framework */
clk_disable_unprepare(dspi->clk);
spi_unregister_master(dspi->master);
- spi_master_put(dspi->master);
return 0;
}