diff options
author | Kent Overstreet <koverstreet@google.com> | 2013-06-14 13:25:01 -0700 |
---|---|---|
committer | Kent Overstreet <kmo@daterainc.com> | 2013-07-05 21:49:34 -0700 |
commit | dc718fa9d2e3ef89d2a68c54510244acd08c6147 (patch) | |
tree | 45d9d62f0573f1e697191c05c38d3036415ed4e6 | |
parent | 80be48c6a3cf9ce48867512ffafed2e9d965f1a2 (diff) |
idr: Rename idr_get_next() -> idr_find_next()
get() implies taking a ref or sometimes an allocation, which this
function definitely does not do - rename it to something more sensible.
Signed-off-by: Kent Overstreet <koverstreet@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>
-rw-r--r-- | drivers/block/drbd/drbd_main.c | 2 | ||||
-rw-r--r-- | drivers/block/drbd/drbd_nl.c | 2 | ||||
-rw-r--r-- | drivers/mtd/mtdcore.c | 2 | ||||
-rw-r--r-- | include/linux/idr.h | 4 | ||||
-rw-r--r-- | lib/idr.c | 6 |
5 files changed, 8 insertions, 8 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index a5dca6affcbb..b84e4b27a77a 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -500,7 +500,7 @@ int conn_lowest_minor(struct drbd_tconn *tconn) int vnr = 0, m; rcu_read_lock(); - mdev = idr_get_next(&tconn->volumes, &vnr); + mdev = idr_find_next(&tconn->volumes, &vnr); m = mdev ? mdev_to_minor(mdev) : -1; rcu_read_unlock(); diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 9e3f441e7e84..8fa7eb17092a 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -2837,7 +2837,7 @@ int get_one_status(struct sk_buff *skb, struct netlink_callback *cb) } if (tconn) { next_tconn: - mdev = idr_get_next(&tconn->volumes, &volume); + mdev = idr_find_next(&tconn->volumes, &volume); if (!mdev) { /* No more volumes to dump on this tconn. * Advance tconn iterator. */ diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index c400c57c394a..eaa1fccc5bdd 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -91,7 +91,7 @@ EXPORT_SYMBOL_GPL(mtd_table_mutex); struct mtd_info *__mtd_next_device(int i) { - return idr_get_next(&mtd_idr, &i); + return idr_find_next(&mtd_idr, &i); } EXPORT_SYMBOL_GPL(__mtd_next_device); diff --git a/include/linux/idr.h b/include/linux/idr.h index b26f8b1540ff..6395da1af6e5 100644 --- a/include/linux/idr.h +++ b/include/linux/idr.h @@ -211,7 +211,7 @@ int idr_alloc(struct idr *idp, void *ptr, int start, int end, gfp_t gfp_mask); int idr_alloc_cyclic(struct idr *idr, void *ptr, int start, int end, gfp_t gfp_mask); int idr_for_each(struct idr *idp, int (*fn)(int id, void *p, void *data), void *data); -void *idr_get_next(struct idr *idp, int *nextid); +void *idr_find_next(struct idr *idp, int *nextid); void *idr_replace(struct idr *idp, void *ptr, int id); void idr_remove(struct idr *idp, int id); void idr_free(struct idr *idp, int id); @@ -262,7 +262,7 @@ static inline void *idr_find(struct idr *idr, int id) * is convenient for a "not found" value. */ #define idr_for_each_entry(idp, entry, id) \ - for (id = 0; ((entry) = idr_get_next(idp, &(id))) != NULL; ++id) + for (id = 0; ((entry) = idr_find_next(idp, &(id))) != NULL; ++id) void __init idr_init_cache(void); diff --git a/lib/idr.c b/lib/idr.c index f7ba96b19787..254e0dce4ead 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -1594,7 +1594,7 @@ int idr_for_each(struct idr *idp, EXPORT_SYMBOL(idr_for_each); /** - * idr_get_next - lookup next object of id to given id. + * idr_find_next - lookup next object of id to given id. * @idp: idr handle * @nextidp: pointer to lookup key * @@ -1605,7 +1605,7 @@ EXPORT_SYMBOL(idr_for_each); * This function can be called under rcu_read_lock(), given that the leaf * pointers lifetimes are correctly managed. */ -void *idr_get_next(struct idr *idp, int *nextidp) +void *idr_find_next(struct idr *idp, int *nextidp) { struct idr_layer *p, *pa[MAX_IDR_LEVEL + 1]; struct idr_layer **paa = &pa[0]; @@ -1646,7 +1646,7 @@ void *idr_get_next(struct idr *idp, int *nextidp) } return NULL; } -EXPORT_SYMBOL(idr_get_next); +EXPORT_SYMBOL(idr_find_next); /** |