diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2016-10-18 16:54:01 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-10 16:38:45 +0100 |
| commit | e22edf53b40fabd70ed61d4c1d1f6dc4cfdbb8ef (patch) | |
| tree | a181ec8c77f8ad98918c486fc204151fb317e9ac | |
| parent | a23a59c56a53db7339e89b0b8b10edf79d1d0865 (diff) | |
gpio: GPIO_GET_LINEHANDLE_IOCTL: Validate line offset
commit e405f9fcb63602d35f7a419ededa3f952a395a72 upstream.
The line offset that is used as an index into the descs array is provided
by userspace and might go beyond the bounds of the array. If that happens
undefined behavior will occur.
Make sure that the offset is within the bounds of the desc array and reject
any requests that specify a value outside of it.
Fixes: d7c51b47ac11 ("gpio: userspace ABI for reading/writing GPIO lines")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/gpio/gpiolib.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6c443ddedb38..ee20b46d798e 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -442,6 +442,11 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip) u32 lflags = handlereq.flags; struct gpio_desc *desc; + if (offset >= gdev->ngpio) { + ret = -EINVAL; + goto out_free_descs; + } + desc = &gdev->descs[offset]; ret = gpiod_request(desc, lh->label); if (ret) |