Drain the child processes stdout before waiting

For very large logs to stdout, this prevents deadlocks.

1 files changed, 7 insertions, 5 deletions

diff --git a/src/lib.rs b/src/lib.rs
index f1f2fcb1..700ca7e9 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -881,10 +881,6 @@ impl Builder {
         }
 
         let mut child = cmd.spawn()?;
-        if !child.wait()?.success() {
-            return Err(io::Error::new(io::ErrorKind::Other,
-                                      "clang exited with non-zero status"));
-        }
 
         let mut preprocessed = child.stdout.take().unwrap();
         let mut file = File::create(if is_cpp {
@@ -893,7 +889,13 @@ impl Builder {
             "__bindgen.i"
         })?;
         io::copy(&mut preprocessed, &mut file)?;
-        Ok(())
+
+        if child.wait()?.success() {
+            Ok(())
+        } else {
+            Err(io::Error::new(io::ErrorKind::Other,
+                               "clang exited with non-zero status"))
+        }
     }
 }