summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorEmilio Cobos Álvarez <emilio@crisal.io>2020-11-25 14:38:00 +0100
committerEmilio Cobos Álvarez <emilio@crisal.io>2020-11-25 14:39:47 +0100
commit7792d633c78d4ad39979e09a6215b656f7ec31f2 (patch)
treeeef3ded814e8dcd47b282982c3a44ab9dcd9f4c5 /src
parentc2b5c46ef4ab2de1281c1d8099daa49621e29794 (diff)
codegen: Minor nits for dynamic function generation.
Diffstat (limited to 'src')
-rw-r--r--src/codegen/dyngen.rs15
-rw-r--r--src/codegen/mod.rs17
2 files changed, 7 insertions, 25 deletions
diff --git a/src/codegen/dyngen.rs b/src/codegen/dyngen.rs
index aab6cac9..4cd01c01 100644
--- a/src/codegen/dyngen.rs
+++ b/src/codegen/dyngen.rs
@@ -2,6 +2,7 @@ use crate::ir::function::Abi;
use proc_macro2::Ident;
/// Used to build the output tokens for dynamic bindings.
+#[derive(Default)]
pub struct DynamicItems {
/// Tracks the tokens that will appears inside the library struct -- e.g.:
/// ```ignore
@@ -74,18 +75,6 @@ pub struct DynamicItems {
init_fields: Vec<proc_macro2::TokenStream>,
}
-impl Default for DynamicItems {
- fn default() -> Self {
- DynamicItems {
- struct_members: vec![],
- struct_implementation: vec![],
- runtime_checks: vec![],
- constructor_inits: vec![],
- init_fields: vec![],
- }
- }
-}
-
impl DynamicItems {
pub fn new() -> Self {
Self::default()
@@ -141,7 +130,7 @@ impl DynamicItems {
}
}
- pub fn add_function(
+ pub fn push(
&mut self,
ident: Ident,
abi: Abi,
diff --git a/src/codegen/mod.rs b/src/codegen/mod.rs
index a62979b0..64f95f4c 100644
--- a/src/codegen/mod.rs
+++ b/src/codegen/mod.rs
@@ -3805,7 +3805,7 @@ impl CodeGenerator for Function {
TypeKind::Void => quote! {()},
_ => return_item.to_rust_ty_or_opaque(ctx, &()),
};
- result.dynamic_items().add_function(
+ result.dynamic_items().push(
ident,
abi,
args,
@@ -4105,17 +4105,10 @@ pub(crate) fn codegen(
&(),
);
- if context.options().dynamic_library_name.is_some() {
- let lib_ident = context.rust_ident(
- context.options().dynamic_library_name.as_ref().unwrap(),
- );
- let check_struct_ident = context.rust_ident(
- [
- "Check",
- context.options().dynamic_library_name.as_ref().unwrap(),
- ]
- .join(""),
- );
+ if let Some(ref lib_name) = context.options().dynamic_library_name {
+ let lib_ident = context.rust_ident(lib_name);
+ let check_struct_ident =
+ context.rust_ident(format!("Check{}", lib_name));
let dynamic_items_tokens = result
.dynamic_items()
.get_tokens(lib_ident, check_struct_ident);