diff options
author | Emilio Cobos Álvarez <ecoal95@gmail.com> | 2016-10-18 23:31:14 +0200 |
---|---|---|
committer | Emilio Cobos Álvarez <ecoal95@gmail.com> | 2016-10-19 10:26:51 +0200 |
commit | f2d4bd9a99f90adc6e9b1ad1e227e5fff2e15658 (patch) | |
tree | 78a0643fb6e08df7928894e4ded5326e825ab18e /src | |
parent | 8eb00107f565b53e398f7868d9d4e7ca0bdfa2d8 (diff) |
ir: Nitpicks of the last docs review that I forgot to push.
I forgot to push when I r=fitzgen in #99.
Diffstat (limited to 'src')
-rw-r--r-- | src/ir/item.rs | 15 | ||||
-rw-r--r-- | src/ir/mod.rs | 6 | ||||
-rw-r--r-- | src/ir/ty.rs | 6 |
3 files changed, 14 insertions, 13 deletions
diff --git a/src/ir/item.rs b/src/ir/item.rs index da0e6aba..18f912c1 100644 --- a/src/ir/item.rs +++ b/src/ir/item.rs @@ -82,10 +82,10 @@ impl ItemCanonicalPath for ItemId { /// module, a type, a function, or a variable (see `ItemKind` for more /// information). /// -/// Items form a tree, and each item only stores the id of the parent. +/// Items form a graph, and each item only stores the id of the parent. /// -/// The root of this tree is the "root module", a meta-item used to hold all the -/// top-level items. +/// The entry-point of this graph is the "root module", a meta-item used to hold +/// all the top-level items. /// /// An item may have a comment, and annotations (see the `annotations` module). /// @@ -163,8 +163,8 @@ impl Item { /// they aren't. /// /// This function is used to determine when the codegen phase should call - /// `codegen` on an item, since it's assumed that any item that is not - /// top-level will be generated by its parent. + /// `codegen` on an item, since any item that is not top-level will be + /// generated by its parent. pub fn is_toplevel(&self, ctx: &BindgenContext) -> bool { // FIXME: Workaround for some types falling behind when parsing weird // stl classes, for example. @@ -610,9 +610,8 @@ impl ClangItemParser for Item { Self::from_ty_or_ref_with_id(ItemId::next(), ty, location, parent_id, context) } - /// Parse a type, if we know it before hand, or otherwise store it as an - /// `UnresolvedTypeRef`, which means something like "a reference to a type - /// we still don't know". + /// Parse a C++ type. If we find a reference to a type that has not been + /// defined yet, use UnresolvedTypeRef as a placeholder. /// /// This logic is needed to avoid parsing items with the incorrect parent /// and it's sort of complex to explain, so I'll just point to diff --git a/src/ir/mod.rs b/src/ir/mod.rs index 1f7c3130..01f388b8 100644 --- a/src/ir/mod.rs +++ b/src/ir/mod.rs @@ -1,5 +1,7 @@ -//! The module where the Intermediate Representation bindgen uses, and the -//! parsing code that generates it lives. +//! The ir module defines bindgen's intermediate representation. +//! +//! Parsing C/C++ generates the IR, while code generation outputs Rust code from +//! the IR. pub mod annotations; pub mod comp; diff --git a/src/ir/ty.rs b/src/ir/ty.rs index 6a2701fa..d74b1a0e 100644 --- a/src/ir/ty.rs +++ b/src/ir/ty.rs @@ -10,9 +10,9 @@ use clang::{self, Cursor}; /// The base representation of a type in bindgen. /// -/// A type has an optional name, that can't be empty, a `layout` (size, -/// alignment and packedness) if known, a `Kind`, which determines which kind of -/// type it is, and whether the type is const. +/// A type has an optional name, which if present cannot be empty, a `layout` +/// (size, alignment and packedness) if known, a `Kind`, which determines which +/// kind of type it is, and whether the type is const. #[derive(Debug)] pub struct Type { /// The name of the type, or None if it was an unnamed struct or union. |