summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Fitzgerald <fitzgen@gmail.com>2017-01-20 14:14:23 -0800
committerNick Fitzgerald <fitzgen@gmail.com>2017-01-23 09:52:53 -0800
commit5229dc2f1dba07673138b2bafd40f3ea022fa0ba (patch)
treee663777b1a8608272ea01102a15d59d1dee59d6e
parenteba4f310541141e2c5cfd749976f80574c4f6b8e (diff)
Document why we shouldn't be tracing module -> child edges
-rw-r--r--src/ir/item.rs7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/ir/item.rs b/src/ir/item.rs
index df8fd222..ac2d122e 100644
--- a/src/ir/item.rs
+++ b/src/ir/item.rs
@@ -205,7 +205,12 @@ impl TypeCollector for Item {
ItemKind::Var(ref var) => {
types.insert(var.ty());
}
- _ => {} // FIXME.
+ ItemKind::Module(_) => {
+ // Module -> children edges are "weak", and we do not want to
+ // trace them. If we did, then whitelisting wouldn't work as
+ // expected: everything in every module would end up
+ // whitelisted.
+ }
}
}
}